"shutdown now" doesn't shut down the machine anymore

MNT Reform
21

This was the topic in IRC again yesterday. The problem is a regression in 6.15 (6.14 was fine). minute identified that there were several changes in power management in the collabora patch stack like this one: linux/patches6.15/rk3588-mnt-reform2/0037-mfd-rk8xx-Fix-shutdown-handler.patch · main · Reform / reform-debian-packages · GitLab

minute created this MR which drops a bunch of collabora patches which should not be needed for rk3588 reform in the hope that maybe that fixes it as a side-effect: Draft: 6.15 rk3588 fixes (!123) · Merge requests · Reform / reform-debian-packages · GitLab

Unfortunately, while the kernel from that gitlab CI pipeline boots fine, it still shows the problem of not shutting down correctly on classic and pocket reform. Full IRC log here: 2025-06-28.log and the next day 2025-06-29.log

1 Like
22

I’ve debugged and fixed this now. Just waiting for someone else than me to test it and @josch to create a new reform-tools release: lpc: use correct kernel api for poweroff; refactor code (!130) · Merge requests · Reform / MNT Reform Tools · GitLab

The main thing was to register a sys_off_handler instead of the hacky past approach, and to do that correctly. I also used the chance to do another round of refactoring the driver.

3 Likes
23

It works for me for RK3588 Pocket Reform and RK3588 DSI classic Reform, both kernel 6.15.

Thank you so much for your work!

Tomorrow I’ll test that this also works with kernel 6.12 and then we’ll do a new reform-tools release.

2 Likes
24

Funny, I tried that too but it didn’t work.

That must be the difference :slight_smile:

Great news! I’ll try it when I get home. Thanks man!

25

I also see no regression with kernel 6.12 on A311D classic Reform, none on imx8mq classic Reform nor on RK3588 Pocket Reform. I just approved the MR. Once minute gives me the go I’ll cut a new reform-tools release.

1 Like
26

Just an update to confirm that shutdown is now working as expected again on my Pocket. Thank you!

1 Like